SNOW-715504: MFA token cache support #988
Open
+1,729
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
5 times, most recently
from
6eba99f
to
69d80c7
Compare
sfc-gh-jmartinezramirez
changed the title
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
from
a8dff4b
to
67089fc
Compare
sfc-gh-knozderko
requested changes
Jul 29, 2024
Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerWindowsNativeImpl.cs
Outdated
Show resolved
Hide resolved
| @@ -116,13 +134,19 @@ private SFRestRequest BuildLoginRequest() | |||
| { | |||
| loginName = session.properties[SFSessionProperty.USER], | |||
| accountName = session.properties[SFSessionProperty.ACCOUNT], | |||
| // TODO LOCAL TEST MFA temp change should be removed before merge | |||
There was a problem hiding this comment.
why would we need to pretend to be a jdbc driver?
There was a problem hiding this comment.
This was only for testing it should use .NET before complete the PR
There was a problem hiding this comment.
Why can't we just test as .net driver? Is there any particular reason to pretend to be a jdbc driver?
Anyway we need to remove it before merging the PR.
There was a problem hiding this comment.
Yes, we will do it before merging
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
4 times, most recently
from
6af9d1a
to
e36f8ed
Compare
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
2 times, most recently
from
e795b5f
to
9316bbc
Compare
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
from
9316bbc
to
43adef9
Compare
sfc-gh-knozderko
requested changes
Oct 8, 2024
Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerFileImpl.cs
Show resolved
Hide resolved
Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerFileImpl.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerWindowsNativeImpl.cs
Outdated
Show resolved
Hide resolved
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
from
3894dae
to
b1ec82b
Compare
sfc-gh-knozderko
requested changes
Oct 9, 2024
Snowflake.Data.Tests/UnitTests/CredentialManager/SFCredentialManagerTest.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/CredentialManager/SFCredentialManagerTest.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/CredentialManager/SFCredentialManagerTest.cs
Show resolved
Hide resolved
Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerFileImpl.cs
Show resolved
Hide resolved
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
from
0be7aa9
to
ce1b619
Compare
sfc-gh-knozderko
requested changes
Oct 17, 2024
Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerFileImpl.cs
Show resolved
Hide resolved
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
3 times, most recently
from
5d32b9c
to
be6f19d
Compare
sfc-gh-knozderko
requested changes
Oct 22, 2024
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
from
a9cec2f
to
10f124b
Compare
…n cache and passcode for MFA
…word_mfa authenticator. Added mechanism to disable or throw an error if using a different authenticator using passcode in connection.
…ection string without username_password_authentication an exception will be thrown to indicate the user that the passcode should not be used if pooling is enabled or with a minimum pool size greater than 0. Additionally, if the passcode is provided by an argument and not part of the connection string, it will not be used for the session created by the session pool, and the push MFA mechanism will be triggered.
(cherry picked from commit ac28924)
…n is expired or invalid. Multi-factor authentication (MFA) will try to use the passcode from the connection string if available; otherwise, send a Duo push notification to try to authenticate again; if it fails, the token will be removed.
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-715504-MFA-Token-Cache
branch
from
7d959a3
to
3d90b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for MFA token cache.
Checklist
dotnet test)